fix(zen): strip auth header for zen google requests#35324
Open
abeisleem wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
abeisleem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35338
Type of change
What does this PR do?
Zen's public OpenAI-compatible
chat/completionsroute authenticates callers withAuthorization: Bearer <OPENCODE_API_KEY>, but Google-backed upstream requests should usex-goog-api-keyonly.For Gemini-backed Zen models, the proxy was forwarding the incoming
Authorizationheader upstream in addition to settingx-goog-api-key. GCP then treats that bearer token as the upstream auth credential and rejects the request withACCESS_TOKEN_TYPE_UNSUPPORTED/UNAUTHENTICATED.This PR strips the forwarded
Authorizationheader in the Google helper before settingx-goog-api-key, and adds a focused regression test for that header behavior.Relevant Gemini REST docs:
Both docs show API-key-authenticated REST requests using the
x-goog-api-keyheader.How did you verify your code works?
https://opencode.ai/zen/v1/chat/completionswithmodel: gemini-3-flashx-goog-api-keybun test test/providerUsage.test.ts test/googleProvider.test.tsbun typecheckScreenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist